Remove @remix-run/eslint-config dependency #7597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I think we might need to sync up the |
brophdawg11
force-pushed
the
brophdawg11/template-eslint
branch
from
c3211c6
to
47f4896
Compare
brophdawg11
force-pushed
the
brophdawg11/template-eslint
branch
from
689b23f
to
9e499d4
Compare
This reverts commit 47f4896.
brophdawg11
force-pushed
the
brophdawg11/template-eslint
branch
from
9e499d4
to
518e46d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7056, we want to get out of the opinionated game of managing an ESLint config so we want to remove dependencies on
@remix-run/eslint-configso it can be deprecated. We simplified the stacks to use a config based on industry recommended configs (remix-run/indie-stack#261, remix-run/blues-stack#215, remix-run/grunge-stack#172).This PR does the same for all the templates, leveraging the same minimal config as we used in the stacks - mostly based on "recommended" presets.
I also added a helper script for us to use in the future. It's tough to fully validate the templates lint properly in the monorepo with the hoisted deps. I added a new
scripts/lint-templates.shscript that can be run outside the repo and will usecreate-remixto create an app from each of the local templates in atemp/dir, install deps, and runnpm run lint:# In this case, I'm running from a playgrounds/ folder that is a sibling to the remix repo ../remix/scripts/lint-templates.sh [path-to-remix-repo]